fix: change artifactId for java client#865
Merged
Deflaimun merged 1 commit intokurrent-io:masterfrom Apr 18, 2025
Merged
Conversation
|
anh nguyen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Hi ! Thank you for your contribution. Let me take over this PR and implement it on our docs |
Deflaimun
approved these changes
Apr 18, 2025
Deflaimun
added a commit
that referenced
this pull request
Apr 18, 2025
Event Store -> Kurrent EventStoreDB -> KurrentDB kurrent link update docker image org name revert past v24 names revert changes to deprecated client revert some pages where EventStoreDB made more sense giving the versioning revert rebrand clients update go version add python and go docs: Rebrand from EventStore to Kurrent (#828) Co-authored-by: Mark Morrissey <90937442+coloradomorrissey@users.noreply.github.com> Co-authored-by: Hayley Campbell <hayleyjeancampbell@gmail.com> engine: captures 404 page events (#859) engine: modify toc with feedback behavior (#863) engine: additional fix for the toc (#864) docs: change artifactId for java client (#865) Co-authored-by: anh nguyen <nvcc1701@gmail.com>
Deflaimun
added a commit
that referenced
this pull request
Apr 18, 2025
Event Store -> Kurrent EventStoreDB -> KurrentDB kurrent link update docker image org name revert past v24 names revert changes to deprecated client revert some pages where EventStoreDB made more sense giving the versioning revert rebrand clients update go version add python and go docs: Rebrand from EventStore to Kurrent (#828) Co-authored-by: Mark Morrissey <90937442+coloradomorrissey@users.noreply.github.com> Co-authored-by: Hayley Campbell <hayleyjeancampbell@gmail.com> engine: captures 404 page events (#859) engine: modify toc with feedback behavior (#863) engine: additional fix for the toc (#864) docs: change artifactId for java client (#865) Co-authored-by: anh nguyen <nvcc1701@gmail.com>
Deflaimun
added a commit
that referenced
this pull request
Apr 18, 2025
Event Store -> Kurrent EventStoreDB -> KurrentDB kurrent link update docker image org name revert past v24 names revert changes to deprecated client revert some pages where EventStoreDB made more sense giving the versioning revert rebrand clients update go version add python and go docs: Rebrand from EventStore to Kurrent (#828) Co-authored-by: Mark Morrissey <90937442+coloradomorrissey@users.noreply.github.com> Co-authored-by: Hayley Campbell <hayleyjeancampbell@gmail.com> engine: captures 404 page events (#859) engine: modify toc with feedback behavior (#863) engine: additional fix for the toc (#864) docs: change artifactId for java client (#865) Co-authored-by: anh nguyen <nvcc1701@gmail.com>
Contributor
|
hey @nvcc1701. Just out of curiosity. Why did you close the PR? Was it because the CLA signature? |
Contributor
Author
|
hi, im new to contribution, i just not sure do i follow the contribution rules. so i close the mr, and i think i will create new mr, but i see it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses wrong arti factIdissues that occurred during the rebranding from "Event Store" to "Kurrent". The main issue was incorrect article usage - using "db-client-java" instead of "kurrentdb-client" .
Description
Page previews